On Wed, Jun 11, 2014 at 06:10:06PM +0800, Shengzhou Liu wrote:
> +                             i2c@0 {
> +                                     #address-cells = <1>;
> +                                     #size-cells = <0>;
> +                                     reg = <0x0>;
> +
> +                                     sfp@50 {
> +                                             compatible = "optics,sfp";
> +                                             reg = <0x50>;
> +                                     };
> +                             };

What is "sfp"?  Please use generic node names when possible.

I'm not able to easily find what chip this is referring to by googling
"optics sfp".  I suspect this compatible is too vague -- what is the
actual part number?  Could you provide a URL to a description of the
chip?

If "optics" is the correct vendor name, it needs to go into
vendor-prefixes.txt.

-Scott
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to