On Wed, 2014-06-04 at 12:04 -0500, Bhushan Bharat-R65777 wrote:
>
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Wednesday, June 04, 2014 10:12 PM
> > To: Bhushan Bharat-R65777
> > Cc: Greg Kroah-Hartman; linuxppc-dev@lists.ozlabs.org; linux-
> > ker...@vger.kernel.org
> > Subject: Re: [RESEND PATCH] memory: Freescale CoreNet Coherency Fabric error
> > reporting driver
> >
> > On Wed, 2014-06-04 at 03:17 -0500, Bhushan Bharat-R65777 wrote:
> > > > +static int ccf_remove(struct platform_device *pdev) {
> > > > + struct ccf_private *ccf = dev_get_drvdata(&pdev->dev);
> > > > +
> > > > + switch (ccf->info->version) {
> > > > + case CCF1:
> > > > + iowrite32be(0, &ccf->err_regs->errdis);
> > > > + break;
> > > > +
> > > > + case CCF2:
> > > > + iowrite32be(0, &ccf->err_regs->errinten);
> > >
> > > Do you think it is same to disable detection bits in
> > > ccf->err_regs->errdis?
> >
> > Disabling the interrupt is what we're aiming for here, but ccf1 doesn't
> > provide
> > a way to do that separate from disabling detection.
>
> What I wanted to say that do we also need to disable detection (set
> ERRDET_LAE | ERRDET_CV bits in errdis) apart from clearing errinten on
> ccf2 ?
I don't think we "need" to. You could argue that we should for
consistency, though I think there's value in errors continuing to be
detected even without the driver (e.g. can dump the registers in a
debugger).
-Scott
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
