Hi Hou, On Thu, Jan 23, 2014 at 03:29:41AM +0000, b48...@freescale.com wrote: > > -----Original Message----- > > From: Brian Norris [mailto:computersforpe...@gmail.com] > > Sent: Thursday, January 23, 2014 10:12 AM > > To: Hou Zhiqiang-B48286 > > Cc: linux-...@lists.infradead.org; linuxppc-...@ozlabs.org; Wood Scott- > > B07421; Hu Mingkai-B21284; Ezequiel Garcia > > Subject: Re: [PATCH] mtd: m25p80: Make the name of mtd_info fixed > > > > On Mon, Jan 06, 2014 at 02:34:29PM +0800, Hou Zhiqiang wrote: > > > --- a/drivers/mtd/devices/m25p80.c > > > +++ b/drivers/mtd/devices/m25p80.c > > > @@ -1012,7 +1012,8 @@ static int m25p_probe(struct spi_device *spi) > > > if (data && data->name) > > > flash->mtd.name = data->name; > > > else > > > - flash->mtd.name = dev_name(&spi->dev); > > > + flash->mtd.name = kasprintf(GFP_KERNEL, "%s.%d", > > > + id->name, spi->chip_select); > > > > Changing the mtd.name may have far-reaching consequences for users who > > already have mtdparts= command lines. But your concern is probably valid > > for dynamically-determined bus numbers. Perhaps you can edit this patch > > to only change the name when the busnum is dynamically-allocated? > > > It's a good idea, but in the case of mtd_info's name dynamically-allocated > using "mtdparts=..." in command lines is illegal obviously.
I agree that users should never have relied on the dynamically-allocated name. But changing the name for non-dynamic schemes (e.g., where the SPI busnum is a fixed value) is not pleasant for users. > Would you tell > me what side-effect will be brought by the change of mtd_info's name. I can only think of the mtdparts= command line. Otherwise, I don't think the name is very important. Brian _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
