On 01/31/2014 09:58 PM, Michael Ellerman wrote:
On Thu, 2014-16-01 at 23:53:49 UTC, Cody P Schafer wrote:
Signed-off-by: Cody P Schafer <c...@linux.vnet.ibm.com>
---
  arch/powerpc/include/asm/hvcall.h | 6 +++++-
  1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/include/asm/hvcall.h 
b/arch/powerpc/include/asm/hvcall.h
index d8b600b..48d6efa 100644
--- a/arch/powerpc/include/asm/hvcall.h
+++ b/arch/powerpc/include/asm/hvcall.h
@@ -269,11 +269,15 @@
  #define H_COP                 0x304
  #define H_GET_MPP_X           0x314
  #define H_SET_MODE            0x31C
-#define MAX_HCALL_OPCODE       H_SET_MODE
+#define H_GET_24X7_CATALOG_PAGE 0xF078
+#define H_GET_24X7_DATA                0xF07C
+#define H_GET_PERF_COUNTER_INFO 0xF080

Ugh, why the hell did they put them up there.

+#define MAX_HCALL_OPCODE       H_GET_PERF_COUNTER_INFO

We have an array which is sized based on this, which is unpleasant.

I think you're better off putting these below in the platform specific section,
and leaving MAX_HCALL_OPCODE alone. The only downside is you can't use the
hcall tracing to see them.

Ya, I'm aware. I've got them up there as I did want to trace them :) . I don't see a big issue with moving them out of that section, though.

  /* Platform specific hcalls, used by KVM */
  #define H_RTAS                        0xf000



_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to