On Wed, 2014-01-22 at 17:38 +0100, Valentin Longchamp wrote:
> On 01/21/2014 06:01 PM, Scott Wood wrote:
> > On Tue, 2014-01-21 at 17:34 +0100, Valentin Longchamp wrote:
> >> Can you please explicitly tell me how I should build this node ? What other
> >> comments ? Must I be more generic with the name ?
> >>
> >> Something like :
> >>
> >> spi@1 {
> >> compatible = "zarlink,30343", "spidev";
> >
> > Remove "spidev". Any nodes under the SPI controller node will be SPI
> > devices, right? So it doesn't add anything regarding hardware
> > description.
> >
>
> OK.
>
> Thank you for the feedback, I will then send a revised patch as soon as I
> have time.
Oh, and ideally the node name should describe the function of the device
-- "spi" as a node name usually means a SPI controller.
Maybe "ptp_clock@1"?
Also, zarlink should be added to
Documentation/devicetree/bindings/vendor-prefixes.txt
-Scott
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
