On Thu, Dec 12, 2013 at 01:38:36PM +0800, Hou Zhiqiang wrote:
> Add PM support using callback function suspend and resume in
> .driver.pm of spi_driver.
>
> Signed-off-by: Hou Zhiqiang <b48...@freescale.com>
> ---
> v2:
> - Replace .driver.suspend and .driver.resume with .driver.pm
> - Use CONFIG_PM_SLEEP instead of CONFIG_PM
Just noticed v2... My v1 comments still apply.
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -1128,11 +1130,46 @@ static int m25p_remove(struct spi_device *spi)
...
> +static const struct dev_pm_ops m25p_pm = {
> + SET_SYSTEM_SLEEP_PM_OPS(m25p_suspend, m25p_resume)
> +};
This could just be:
static SIMPLE_DEV_PM_OPS(m25p_pm_ops, m25p_suspend, m25p_resume);
>
> static struct spi_driver m25p80_driver = {
> .driver = {
> .name = "m25p80",
> .owner = THIS_MODULE,
> + .pm = &m25p_pm,
> },
> .id_table = m25p_ids,
> .probe = m25p_probe,
Brian
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
