On Fri, Dec 20, 2013 at 09:59:37AM +0800, Gavin Shan wrote: > On Fri, Dec 20, 2013 at 09:35:39AM +0800, Gavin Shan wrote: > >On Thu, Dec 19, 2013 at 05:14:07PM -0600, Brian W Hart wrote: > >>PHB diagnostic buffer may be smaller than PAGE_SIZE, especially when > >>PAGE_SIZE > 4KB. > >> > > > >I think you're talking about that PAGE_SIZE could be configured > >to have variable size (e.g. 4KB). So it's not safe to pass PAGE_SIZE > >to OPAL API opal_pci_get_phb_diag_data2(). Instead, we should pass > >PNV_PCI_DIAG_BUF_SIZE and it makes sense to me :-)
Yeah, I noticed the problem because our test machine has PAGE_SIZE of 64K with the buffer only being 8K. [...] > Sorry, Brian. It has been fixed as part of the following commit, which > has been put into Ben's powerpc-next branch :-) Thank you! _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
