On Sat, Nov 30, 2013 at 10:51:22PM +0000, Gerhard Sittig wrote: > introduce a dt-bindings/ header file for MPC512x clocks, > providing symbolic identifiers for those SoC clocks which > clients will reference from their device tree nodes
There should be a binding document update to go with this, pointing out that this include file defines the set of clock IDs for the MPC512x clocks. Otherwise, this looks fine to me. Mark. > > Cc: Rob Herring <rob.herr...@calxeda.com> > Cc: Pawel Moll <pawel.m...@arm.com> > Cc: Mark Rutland <mark.rutl...@arm.com> > Cc: Stephen Warren <swar...@wwwdotorg.org> > Cc: Ian Campbell <ian.campb...@citrix.com> > Cc: devicet...@vger.kernel.org > Reviewed-by: Mike Turquette <mturque...@linaro.org> # for v3: w/o bdlc, PSC > ipg > Signed-off-by: Gerhard Sittig <g...@denx.de> > --- > include/dt-bindings/clock/mpc512x-clock.h | 69 > +++++++++++++++++++++++++++++ > 1 file changed, 69 insertions(+) > create mode 100644 include/dt-bindings/clock/mpc512x-clock.h > > diff --git a/include/dt-bindings/clock/mpc512x-clock.h > b/include/dt-bindings/clock/mpc512x-clock.h > new file mode 100644 > index 000000000000..9e81b3b99a32 > --- /dev/null > +++ b/include/dt-bindings/clock/mpc512x-clock.h > @@ -0,0 +1,69 @@ > +/* > + * This header provides constants for MPC512x clock specs in DT bindings. > + */ > + > +#ifndef _DT_BINDINGS_CLOCK_MPC512x_CLOCK_H > +#define _DT_BINDINGS_CLOCK_MPC512x_CLOCK_H > + > +#define MPC512x_CLK_DUMMY 0 > +#define MPC512x_CLK_REF 1 > +#define MPC512x_CLK_SYS 2 > +#define MPC512x_CLK_DIU 3 > +#define MPC512x_CLK_VIU 4 > +#define MPC512x_CLK_CSB 5 > +#define MPC512x_CLK_E300 6 > +#define MPC512x_CLK_IPS 7 > +#define MPC512x_CLK_FEC 8 > +#define MPC512x_CLK_SATA 9 > +#define MPC512x_CLK_PATA 10 > +#define MPC512x_CLK_NFC 11 > +#define MPC512x_CLK_LPC 12 > +#define MPC512x_CLK_MBX_BUS 13 > +#define MPC512x_CLK_MBX 14 > +#define MPC512x_CLK_MBX_3D 15 > +#define MPC512x_CLK_AXE 16 > +#define MPC512x_CLK_USB1 17 > +#define MPC512x_CLK_USB2 18 > +#define MPC512x_CLK_I2C 19 > +#define MPC512x_CLK_MSCAN0_MCLK 20 > +#define MPC512x_CLK_MSCAN1_MCLK 21 > +#define MPC512x_CLK_MSCAN2_MCLK 22 > +#define MPC512x_CLK_MSCAN3_MCLK 23 > +#define MPC512x_CLK_BDLC 24 > +#define MPC512x_CLK_SDHC 25 > +#define MPC512x_CLK_PCI 26 > +#define MPC512x_CLK_PSC_MCLK_IN 27 > +#define MPC512x_CLK_SPDIF_TX 28 > +#define MPC512x_CLK_SPDIF_RX 29 > +#define MPC512x_CLK_SPDIF_MCLK 30 > +#define MPC512x_CLK_SPDIF 31 > +#define MPC512x_CLK_AC97 32 > +#define MPC512x_CLK_PSC0_MCLK 33 > +#define MPC512x_CLK_PSC1_MCLK 34 > +#define MPC512x_CLK_PSC2_MCLK 35 > +#define MPC512x_CLK_PSC3_MCLK 36 > +#define MPC512x_CLK_PSC4_MCLK 37 > +#define MPC512x_CLK_PSC5_MCLK 38 > +#define MPC512x_CLK_PSC6_MCLK 39 > +#define MPC512x_CLK_PSC7_MCLK 40 > +#define MPC512x_CLK_PSC8_MCLK 41 > +#define MPC512x_CLK_PSC9_MCLK 42 > +#define MPC512x_CLK_PSC10_MCLK 43 > +#define MPC512x_CLK_PSC11_MCLK 44 > +#define MPC512x_CLK_PSC_FIFO 45 > +#define MPC512x_CLK_PSC0 46 > +#define MPC512x_CLK_PSC1 47 > +#define MPC512x_CLK_PSC2 48 > +#define MPC512x_CLK_PSC3 49 > +#define MPC512x_CLK_PSC4 50 > +#define MPC512x_CLK_PSC5 51 > +#define MPC512x_CLK_PSC6 52 > +#define MPC512x_CLK_PSC7 53 > +#define MPC512x_CLK_PSC8 54 > +#define MPC512x_CLK_PSC9 55 > +#define MPC512x_CLK_PSC10 56 > +#define MPC512x_CLK_PSC11 57 > + > +#define MPC512x_CLK_LAST_PUBLIC 57 > + > +#endif > -- > 1.7.10.4 > > _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
