Re: [PATCH v3 3/4] ASoC: fsl_ssi: Add dual fifo mode support

[Timur Tabi]

Nicolin Chen wrote:

+       if (ssi_private->use_dual_fifo) {
+               write_ssi_mask(&ssi->srcr, 0, CCSR_SSI_SRCR_RFEN1);
+               write_ssi_mask(&ssi->stcr, 0, CCSR_SSI_STCR_TFEN1);
+               write_ssi_mask(&ssi->scr, 0, CCSR_SSI_SCR_TCH_EN);
+       } else {
+               write_ssi_mask(&ssi->srcr, CCSR_SSI_SRCR_RFEN1, 0);
+               write_ssi_mask(&ssi->stcr, CCSR_SSI_STCR_TFEN1, 0);
+               write_ssi_mask(&ssi->scr, CCSR_SSI_SCR_TCH_EN, 0);
+       }

Why do you need the "else" part?  Why can't you just do this:

if (ssi_private->use_dual_fifo) {
        write_ssi_mask(&ssi->srcr, 0, CCSR_SSI_SRCR_RFEN1);
        write_ssi_mask(&ssi->stcr, 0, CCSR_SSI_STCR_TFEN1);
        write_ssi_mask(&ssi->scr, 0, CCSR_SSI_SCR_TCH_EN);
}
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev