On Oct 14, 2013, at 2:26 PM, Kumar Gala wrote:
>
> On Oct 14, 2013, at 6:37 AM, Xie Xiaobo wrote:
>
>> The QUICC Engine (QE) is a communications coprocessors on Freescale
>> embedded processors. The QE had been applied in PowerPC architecture
>> previously, and it will be applied in ARM architecture too.
>> So move the qe_lib from arch/powerpc to driver/ firstly.
>>
>> Signed-off-by: Xie Xiaobo <x....@freescale.com>
>> ---
>> arch/powerpc/Kconfig | 2 -
>> arch/powerpc/include/asm/immap_qe.h | 491 -----------------
>> arch/powerpc/include/asm/qe.h | 740 -------------------------
>> arch/powerpc/include/asm/qe_ic.h | 144 -----
>> arch/powerpc/include/asm/ucc.h | 64 ---
>> arch/powerpc/include/asm/ucc_fast.h | 244 --------
>> arch/powerpc/include/asm/ucc_slow.h | 290 ----------
>> arch/powerpc/platforms/85xx/mpc85xx_mds.c | 4 +-
>> arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 4 +-
>> arch/powerpc/platforms/Kconfig | 19 -
>> arch/powerpc/sysdev/Makefile | 1 -
>> arch/powerpc/sysdev/qe_lib/Kconfig | 27 -
>> arch/powerpc/sysdev/qe_lib/Makefile | 10 -
>> arch/powerpc/sysdev/qe_lib/gpio.c | 317 -----------
>> arch/powerpc/sysdev/qe_lib/qe.c | 708 ------------------------
>> arch/powerpc/sysdev/qe_lib/qe_ic.c | 501 -----------------
>> arch/powerpc/sysdev/qe_lib/qe_ic.h | 103 ----
>> arch/powerpc/sysdev/qe_lib/qe_io.c | 218 --------
>> arch/powerpc/sysdev/qe_lib/ucc.c | 213 -------
>> arch/powerpc/sysdev/qe_lib/ucc_fast.c | 364 ------------
>> arch/powerpc/sysdev/qe_lib/ucc_slow.c | 380 -------------
>> arch/powerpc/sysdev/qe_lib/usb.c | 56 --
> Before this is moved you should address the PPC specific issues in the code.
> Use of PPC_LIB_RHEAP, the IO macros which are not cross platform, etc.
>
> Also, copy linux-kernel list as I'm not sure drivers/qe would be the
> recommendation location for this to end up at.
Additionally, some of this should move to using standard driver models that now
exist. For example qe_ic.{c,h} should possibly look at going into
drivers/irqchip/. gpio.c should be looked to use gpiolib and move into
drivers/gpio. Some of the pinmux that exists in qe.c and ucc.c should look at
the drivers/pinctrl and there is some amount of clk config that I wonder if it
could move the common clk API and drivers/clk.
There will still be some qe_lib specific code, but vastly reduced.
- k
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
