* Mark Salter <msal...@redhat.com> wrote:
> Remove messy dependencies from PARPORT_PC by having it depend on one
> Kconfig symbol (ARCH_MAY_HAVE_PC_PARPORT) and having architectures
> which need it, select ARCH_MAY_HAVE_PC_PARPORT in arch/*/Kconfig.
> New architectures are unlikely to need PARPORT_PC, so this avoids
> having an ever growing list of architectures to exclude. Those
> architectures which do select ARCH_MAY_HAVE_PC_PARPORT in this
> patch are the ones which have an asm/parport.h (or use the generic
> version).
>
> Signed-off-by: Mark Salter <msal...@redhat.com>
> CC: Richard Henderson <r...@twiddle.net>
> CC: linux-al...@vger.kernel.org
> CC: Vineet Gupta <vgu...@synopsys.com>
> CC: Russell King <li...@arm.linux.org.uk>
> CC: linux-arm-ker...@lists.infradead.org
> CC: Tony Luck <tony.l...@intel.com>
> CC: Fenghua Yu <fenghua...@intel.com>
> CC: linux-i...@vger.kernel.org
> CC: Geert Uytterhoeven <ge...@linux-m68k.org>
> CC: linux-m...@lists.linux-m68k.org
> CC: Michal Simek <mon...@monstr.eu>
> CC: microblaze-ucli...@itee.uq.edu.au
> CC: Ralf Baechle <r...@linux-mips.org>
> CC: linux-m...@linux-mips.org
> CC: "James E.J. Bottomley" <j...@parisc-linux.org>
> CC: Helge Deller <del...@gmx.de>
> CC: linux-par...@vger.kernel.org
> CC: Benjamin Herrenschmidt <b...@kernel.crashing.org>
> CC: Paul Mackerras <pau...@samba.org>
> CC: linuxppc-dev@lists.ozlabs.org
> CC: Paul Mundt <let...@linux-sh.org>
> CC: linux...@vger.kernel.org
> CC: "David S. Miller" <da...@davemloft.net>
> CC: sparcli...@vger.kernel.org
> CC: Guan Xuetao <g...@mprc.pku.edu.cn>
> CC: Thomas Gleixner <t...@linutronix.de>
> CC: Ingo Molnar <mi...@redhat.com>
> CC: "H. Peter Anvin" <h...@zytor.com>
> CC: x...@kernel.org
> ---
> drivers/parport/Kconfig | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/parport/Kconfig b/drivers/parport/Kconfig
> index 70694ce..a079b18 100644
> --- a/drivers/parport/Kconfig
> +++ b/drivers/parport/Kconfig
> @@ -31,13 +31,17 @@ menuconfig PARPORT
>
> If unsure, say Y.
>
> +config ARCH_MAY_HAVE_PC_PARPORT
> + bool
> + help
> + Select this config option from the architecture Kconfig if
> + the architecture may have PC parallel port hardware.
> +
> if PARPORT
>
> config PARPORT_PC
> tristate "PC-style hardware"
> - depends on (!SPARC64 || PCI) && !SPARC32 && !M32R && !FRV && !S390 && \
> - (!M68K || ISA) && !MN10300 && !AVR32 && !BLACKFIN && \
> - !XTENSA && !CRIS && !H8300
> + depends on ARCH_MAY_HAVE_PC_PARPORT
>
> ---help---
> You should say Y here if you have a PC-style parallel port. All
Since it's not a permission to have a parallel port but a possibility,
I suspect the whole series needs a:
s/MAY_HAVE/MIGHT_HAVE
s/may have/might have
Otherwise:
Acked-by: Ingo Molnar <mi...@kernel.org>
Thanks,
Ingo
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
