On Fri, 2013-09-13 at 02:35 -0500, Kushwaha Prabhakar-B32579 wrote: > > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Thursday, September 12, 2013 5:11 AM > > To: Kushwaha Prabhakar-B32579 > > Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Jain > > Priyanka-B32167; Aggrwal Poonam-B10812 > > Subject: Re: [PATCH 1/2] powerpc/fsl-booke: Add initial T104x_QDS board > > support > > > > On Wed, 2013-09-11 at 12:28 +0530, Prabhakar Kushwaha wrote: > > > + aliases { > > > + /* TODO */ > > > + }; > > > > TODO? Did you mean this patch as an RFC? > > > > > actually, this patch is not adding in dpaa related node(fman,bman etc). > I am keeping place holder for alias of Ethernet nodes.
If you don't have any board-level aliases yet, then just don't include the aliases node in this file. > > Also, whitespace. > > > > does whitespace is not captured in checkpatch? Not in dts files. > > Maybe some of this stuff could be put in a common dtsi between t1040 and > > t1042? > > > > Ideally for t1042 you'd just take the entire t1040 tree as an include, > > and add the switch > > > > means, I just create T1042qds.dts and for T1040.dts include t1042dts + switch Is it t1040 that has the switch or t1042? -Scott _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev