On Thu, 2013-08-08 at 09:40 +0530, Anshuman Khandual wrote: > On 08/07/2013 03:08 PM, Mahesh J Salgaonkar wrote: > > From: Mahesh Salgaonkar <mah...@linux.vnet.ibm.com> > > > > This patch splits the common exception prolog logic into two parts to > > facilitate reuse of existing code in the next patch. The second part will > > be reused in the machine check exception routine in the next patch. > > > > Please avoid describing the functionality as a requirement for upcoming > sibling patches. Justification to split the code should be generic functional > or code organizational requirement. We should avoid the word "next patch" in > the commit message, as it would be confusing when you read it later point of > time. The commit message should be self sufficient pertaining to the exact > code change set in consideration.
Ugh ? It's absolutely common practice to have a patch doing such a split *specifically* for the purpose of subsequent patches.... In fact it's even *recommended* to separate the split from the subsequent code change as the code split patch should be a nop, and it makes the subsequent patch a lot easier to review. Ben. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
