On 07/23/2013 02:47:18 AM, Liu Po-B43644 wrote:
> > + partition@1900000 {
> > + /* 7MB for User Area */
> > + reg = <0x01900000 0x00700000>;
> > + label = "NAND User area";
> > + };
>
> Above you say there's 4 GiB of NAND, but here you define
partitions that
> only cover 32 MiB.
Can I set one partion include all other space(4GB- 32MB) with label
name "Others"?
Are you sure you don't want to leave more room for the RFS? And what
is the difference between "user area" and "others"?
> > diff --git a/arch/powerpc/platforms/85xx/c293pcie.c
> > b/arch/powerpc/platforms/85xx/c293pcie.c
> > new file mode 100644
> > index 0000000..75dda12
> > --- /dev/null
> > +++ b/arch/powerpc/platforms/85xx/c293pcie.c
> > @@ -0,0 +1,82 @@
> > +/*
> > + * C293PCIE Board Setup
> > + *
> > + * Copyright 2013 Freescale Semiconductor Inc.
> > + *
> > + * This program is free software; you can redistribute it
and/or
> > +modify it
> > + * under the terms of the GNU General Public License as
published
> > +by the
> > + * Free Software Foundation; either version 2 of the License,
or
> > +(at your
> > + * option) any later version.
> > + */
> > +
> > +#include <linux/stddef.h>
> > +#include <linux/kernel.h>
> > +#include <linux/pci.h>
> > +#include <linux/delay.h>
> > +#include <linux/interrupt.h>
> > +#include <linux/of_platform.h>
> > +
> > +#include <asm/time.h>
> > +#include <asm/machdep.h>
> > +#include <asm/pci-bridge.h>
> > +#include <mm/mmu_decl.h>
> > +#include <asm/prom.h>
> > +#include <asm/udbg.h>
> > +#include <asm/mpic.h>
> > +
> > +#include <sysdev/fsl_soc.h>
> > +#include <sysdev/fsl_pci.h>
> > +
> > +#include "mpc85xx.h"
>
> Are you sure you need all of these? I don't see any delays, for
example.
Thanks, I'll test and remove redundant includes.
Don't base it purely on testing -- you don't want to rely on
accidentally picking up a needed include from some other include (which
could change down the road). Base it on whether this file uses
something declared by the header in question.
-Scott
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
