On 06/27/2013 05:22 PM, Michael Ellerman wrote:
> 
> On Wed, 2013-06-26 at 15:28 +0530, Anshuman Khandual wrote:
>>> @@ -117,6 +117,7 @@
>>>      (EVENT_UNIT_MASK      << EVENT_UNIT_SHIFT)             |       \
>>>      (EVENT_COMBINE_MASK   << EVENT_COMBINE_SHIFT)          |       \
>>>      (EVENT_MARKED_MASK    << EVENT_MARKED_SHIFT)           |       \
>>> +    (1ull                 << EVENT_CONFIG_EBB_SHIFT)       |       \
>>
>> We should define this macro like EVENT_MARKED_MASK
>>
>> #define EVENT_EBB_MASK       0x1
>>
>> Numeric value of "1ull" stands out odd in the scheme.
> 
> Yeah I guess.
> 
> Would you like it in blue? :)
> 

:) No, I meant probably a macro definition would be cool.

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to