On Mon, Jun 24, 2013 at 02:25:59PM -0500, Nathan Fontenot wrote: > On 06/24/2013 02:16 PM, Seth Jennings wrote: > > On Mon, Jun 24, 2013 at 12:18:04PM -0500, Seth Jennings wrote: > >> On Mon, Jun 24, 2013 at 09:14:23AM -0500, Nathan Fontenot wrote: > >>> The topology update code that updates the cpu node registration in sysfs > >>> should not be called while in stop_machine(). The register/unregister > >>> calls take a lock and may sleep. > >>> > >>> This patch moves these calls outside of the call to stop_machine(). > >>> > >>> Signed-off-by:Nathan Fontenot <nf...@linux.vnet.ibm.com> > >> > >> Reviewed-by: Seth Jennings <sjenn...@linux.vnet.ibm.com> > > > > Gah! I _knew_ I should have waited for my cross compiler to finish > > building. This thing doesn't build: > > > > CC arch/powerpc/mm/numa.o > > /home/sjennings/ltc/linux/arch/powerpc/mm/numa.c: In function > > 'arch_update_cpu_topology': > > /home/sjennings/ltc/linux/arch/powerpc/mm/numa.c:1486: error: 'update' > > undeclared (first use in this function) > > /home/sjennings/ltc/linux/arch/powerpc/mm/numa.c:1486: error: (Each > > undeclared identifier is reported only once > > /home/sjennings/ltc/linux/arch/powerpc/mm/numa.c:1486: error: for each > > function it appears in.) > > > > s/update/ud/ in the *_cpu_under_node() calls. > > Oops! Time for patch submission re-education training.
We've all done it, but yes :) I try to stick to: 1. write code. 2. build code. 3. test code. 4. submit code. I imagine you tested an early version of the patch, or on RHEL or something, but that can bite you like this. Whenever possible you should build & test the exact code you submit, though that can be hard when trees are moving quickly underneath you. cheers _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
