Nathan Fontenot <nf...@linux.vnet.ibm.com> writes:

> Building with CONFIG_TRANSPARENT_HUGEPAGE disabled causes the following
> build wearnings;
>
> powerpc/arch/powerpc/include/asm/mmu-hash64.h: In function ‘__hash_page_thp’:
> powerpc/arch/powerpc/include/asm/mmu-hash64.h:354: warning: no return 
> statement in function returning non-void
>
> This patch adds a return -1 to the static inline for __hash_page_thp()
> to correct the warnings.
>
> Signed-off-by: Nathan Fontenot <nf...@linux.vnet.ibm.com>

Reviewed-by: Aneesh Kumar K.V <aneesh.ku...@linux.vnet.ibm.com>

Wondering why i am not finding this

[root@llmp24l02 thp]# make arch/powerpc/mm/hash_utils_64.o
....
.....
  CC      arch/powerpc/mm/hash_utils_64.o
[root@llmp24l02 thp]# grep TRANSPARENT_HUGEPAGE .config
CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE=y
# CONFIG_TRANSPARENT_HUGEPAGE is not set
[root@llmp24l02 thp]# 
[root@llmp24l02 thp]# gcc --version
gcc (GCC) 4.7.2 20121109 (Red Hat 4.7.2-8)
Copyright (C) 2012 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.


> ---
>  arch/powerpc/include/asm/mmu-hash64.h |    1 +
>  1 file changed, 1 insertion(+)
>
> Index: powerpc/arch/powerpc/include/asm/mmu-hash64.h
> ===================================================================
> --- powerpc.orig/arch/powerpc/include/asm/mmu-hash64.h        2013-06-24 
> 07:54:08.000000000 -0500
> +++ powerpc/arch/powerpc/include/asm/mmu-hash64.h     2013-06-24 
> 08:07:56.000000000 -0500
> @@ -351,6 +351,7 @@
>                                 int ssize, unsigned int psize)
>  {
>       BUG();
> +     return -1;
>  }
>  #endif
>  extern void hash_failure_debug(unsigned long ea, unsigned long access,

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to