On Sat, 2013-06-01 at 14:49 +1000, Benjamin Herrenschmidt wrote:
> On Thu, 2013-04-25 at 15:48 +0530, Aruna Balakrishnaiah wrote:
> > This patch set exploits the pstore subsystem to read details of rtas
> > partition
> > in NVRAM to a separate file in /dev/pstore. For instance, rtas details will
> > be
> > stored in a file named [rtas-nvram-4].
> >
> .../...
>
> > diff --git a/include/linux/pstore.h b/include/linux/pstore.h
> > index 75d0176..d7a8fe9 100644
> > --- a/include/linux/pstore.h
> > +++ b/include/linux/pstore.h
> > @@ -35,6 +35,8 @@ enum pstore_type_id {
> > PSTORE_TYPE_MCE = 1,
> > PSTORE_TYPE_CONSOLE = 2,
> > PSTORE_TYPE_FTRACE = 3,
> > + /* PPC64 partition types */
> > + PSTORE_TYPE_PPC_RTAS = 4,
> > PSTORE_TYPE_UNKNOWN = 255
> > };
> >
>
> Not sure about that list...
>
> What do you mean by "RTAS" ? The error logs ? What about our "common"
> partition (firmware settings ?). We should probably at least define
> a generic PSTORE_TYPE_FIRMWARE for firmware private stuff...
Scrap it, I just noticed your next patch doing that,... see comment
there.
Cheers,
Ben.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
