> -----Original Message----- > From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] > Sent: Wednesday, April 24, 2013 12:19 PM > To: Jia Hongtao-B38951 > Cc: Michael Ellerman; Wood Scott-B07421; linuxppc-dev@lists.ozlabs.org > Subject: Re: [PATCH 1/2] powerpc: Move opcode definitions from > kvm/emulate.c to asm/ppc-opcode.h > > On Tue, 2013-04-23 at 06:36 +0000, Jia Hongtao-B38951 wrote: > > These definitions are firstly used by KVM defined like OP_31_XOP_TRAP. > > Two ways to extract these definitions for public use: > > > > 1. Like this patch did. For keeping the KVM code that using these > > definitions unchanged we do not update them to match. > > > > 2. Move these definitions to another .h file like my last patch did: > > http://patchwork.ozlabs.org/patch/235646/ > > You can see the comments there. > > There's a better way ... but it's more work. > > All opcodes are based on a primary opcode and a potential secondary > opcode. You could/should rework ppc-opcodes.h to in fact define them > all that way as well, which would "reconcile" the KVM way and the > existing stuff. > > Cheers, > Ben. >
Agree. But I'm afraid to say that I'm too busy to do this "more work" right now. Could we defer this work for some time? Thanks. - Hongtao _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
