> -----Original Message----- > From: Linuxppc-dev [mailto:linuxppc-dev- > bounces+poonam.aggrwal=freescale....@lists.ozlabs.org] On Behalf Of > Leekha Shaveta-B20052 > Sent: Monday, April 08, 2013 10:18 AM > To: Kumar Gala > Cc: linuxppc-dev@lists.ozlabs.org list > Subject: RE: [PATCH 1/4][v2] powerpc/fsl-booke: Add initial silicon > device tree files for B4860 and B4420 > > > > -----Original Message----- > From: Leekha Shaveta-B20052 > Sent: Friday, April 05, 2013 9:13 PM > To: 'Kumar Gala' > Cc: linuxppc-dev@lists.ozlabs.org list > Subject: RE: [PATCH 1/4][v2] powerpc/fsl-booke: Add initial silicon > device tree files for B4860 and B4420 > > > > -----Original Message----- > From: Kumar Gala [mailto:ga...@kernel.crashing.org] > Sent: Friday, April 05, 2013 7:53 PM > To: Leekha Shaveta-B20052 > Cc: linuxppc-dev@lists.ozlabs.org list > Subject: Re: [PATCH 1/4][v2] powerpc/fsl-booke: Add initial silicon > device tree files for B4860 and B4420 > > > On Apr 5, 2013, at 1:33 AM, Shaveta Leekha wrote: > > > B4860 and B4420 are similar that share some commonalities > > > > * common features have been added in b4si-pre.dtsi and b4si-post.dtsi > > * differences are added in respective silicon files of B4860 and B4420 > > > > There are several things missing from the device trees of B4860 and > B4420: > > > > * DPAA related nodes (Qman, Bman, Fman, Rman) > > * DSP related nodes/information > > * serdes, sfp(security fuse processor), thermal, gpio, maple, cpri, > > quad timers nodes > > > > Signed-off-by: Shaveta Leekha <shav...@freescale.com> > > Signed-off-by: Zhao Chenhui <chenhui.z...@freescale.com> > > Signed-off-by: Li Yang <le...@freescale.com> > > Signed-off-by: Tang Yuantian <yuantian.t...@freescale.com> > > Signed-off-by: Varun Sethi <varun.se...@freescale.com> > > Signed-off-by: Minghuan Lian <minghuan.l...@freescale.com> > > Signed-off-by: Ramneek Mehresh <ramneek.mehr...@freescale.com> > > Signed-off-by: Kumar Gala <ga...@kernel.crashing.org> > > Signed-off-by: Andy Fleming <aflem...@freescale.com> > > Signed-off-by: Vakul Garg <va...@freescale.com> > > --- > > v2: > > - incorporated review comments on commits message > > - change unit address of cpu nodes to match the reg property > > > > arch/powerpc/boot/dts/fsl/b4420si-post.dtsi | 94 ++++++++++ > > arch/powerpc/boot/dts/fsl/b4420si-pre.dtsi | 49 +++++ > > arch/powerpc/boot/dts/fsl/b4860si-post.dtsi | 138 ++++++++++++++ > > arch/powerpc/boot/dts/fsl/b4860si-pre.dtsi | 59 ++++++ > > arch/powerpc/boot/dts/fsl/b4si-post.dtsi | 262 > +++++++++++++++++++++++++++ > > arch/powerpc/boot/dts/fsl/b4si-pre.dtsi | 65 +++++++ > > 6 files changed, 667 insertions(+), 0 deletions(-) create mode 100644 > > arch/powerpc/boot/dts/fsl/b4420si-post.dtsi > > create mode 100644 arch/powerpc/boot/dts/fsl/b4420si-pre.dtsi > > create mode 100644 arch/powerpc/boot/dts/fsl/b4860si-post.dtsi > > create mode 100644 arch/powerpc/boot/dts/fsl/b4860si-pre.dtsi > > create mode 100644 arch/powerpc/boot/dts/fsl/b4si-post.dtsi > > create mode 100644 arch/powerpc/boot/dts/fsl/b4si-pre.dtsi > > Is there a reason you didn't get rid of b4si-pre.dtsi and just merge it > into b4860si-pre.dtsi & b4420-pre.dtsi? > [SL] No particular reason. I have just tried to re-factored these files > as you have suggested. Hence managed the commonalities in B4 files and > differences in B4860's and B4420's respective files to reduce duplicity. > > Regards, > Shaveta > > [SL] Kumar, please suggest.
Please suggest , if this re-factoring for pre-si dtsi should not be required. This was done to keep things uniform. Accordingly we will send a re-spin if required. Regards Poonam > > Regards, > Shaveta > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev