On Apr 2, 2013, at 12:49 PM, Scott Wood wrote: > On 04/02/2013 01:35:05 AM, Jia Hongtao-B38951 wrote: >> > -----Original Message----- >> > From: Wood Scott-B07421 >> > Sent: Saturday, March 30, 2013 5:55 AM >> > To: Jia Hongtao-B38951 >> > Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org; Wood Scott- >> > B07421; Li Yang-R58472; Jia Hongtao-B38951 >> > Subject: Re: [PATCH 2/2] powerpc/85xx: workaround for chips with MSI >> > hardware errata >> > >> > On 03/25/2013 10:28:47 PM, Jia Hongtao wrote: >> > > The MPIC version 2.0 has a MSI errata (errata PIC1 of mpc8544), It >> > > causes that neither MSI nor MSI-X can work fine. This is a workaround >> > > to allow MSI-X to function properly. >> > > >> > > Signed-off-by: Liu Shuo <soniccat....@gmail.com> >> > > Signed-off-by: Li Yang <le...@freescale.com> >> > > Signed-off-by: Jia Hongtao <hongtao....@freescale.com> >> > > --- >> > > arch/powerpc/sysdev/fsl_msi.c | 47 >> > > ++++++++++++++++++++++++++++++++++++++++--- >> > > 1 file changed, 44 insertions(+), 3 deletions(-) >> > > >> > > diff --git a/arch/powerpc/sysdev/fsl_msi.c >> > > b/arch/powerpc/sysdev/fsl_msi.c index 178c994..d2f8040 100644 >> > > --- a/arch/powerpc/sysdev/fsl_msi.c >> > > +++ b/arch/powerpc/sysdev/fsl_msi.c >> > > @@ -28,6 +28,8 @@ >> > > #include "fsl_msi.h" >> > > #include "fsl_pci.h" >> > > >> > > +#define MSI_HW_ERRATA_ENDIAN 0x00000010 >> It seems Kumar like put this just in fsl_msi.c. >> Here is the comments from Kumar few days ago: >> "Is there any reason to put this in fsl_msi.h rather than just in >> fsl_msi.c itself?" >> I think the all the #defines should be together. >> Ether all in .h or all in .c. >> In this case I prefer your idea. > > I don't care which file they go in (though .c is probably better if they > don't need wider visibility), just as long as they're together. > > -Scott
Agreed, I didn't realize it was with mixed with the FSL_PIC_IP_* defines. So this should be with: #define FSL_PIC_IP_MASK 0x0000000F #define FSL_PIC_IP_MPIC 0x00000001 #define FSL_PIC_IP_IPIC 0x00000002 #define FSL_PIC_IP_VMPIC 0x00000003 in fsl_msi.h - k _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
