On 03/19/2013 02:10:38 AM, Wang Dongsheng-B40534 wrote:
> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Tuesday, March 19, 2013 7:36 AM
> To: Wang Dongsheng-B40534
> Cc: linuxppc-dev@lists.ozlabs.org; ga...@kernel.crashing.org
> Subject: Re: [PATCH][UPSTEAM] powerpc/mpic: add irq_set_wake support
>
> On 01/30/2013 09:10:23 PM, Wang Dongsheng wrote:
> > Add irq_set_wake support. Just add IRQF_NO_SUSPEND to
> > desc->action->flag.
> > So the wake up interrupt will not be disable in
suspend_device_irqs.
> >
> > Signed-off-by: Wang Dongsheng <dongsheng.w...@freescale.com>
> > ---
> > arch/powerpc/sysdev/mpic.c | 15 +++++++++++++++
> > 1 files changed, 15 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/powerpc/sysdev/mpic.c
b/arch/powerpc/sysdev/mpic.c
> > index 9c6e535..2ed0220 100644
> > --- a/arch/powerpc/sysdev/mpic.c
> > +++ b/arch/powerpc/sysdev/mpic.c
> > @@ -920,6 +920,18 @@ int mpic_set_irq_type(struct irq_data *d,
> > unsigned int flow_type)
> > return IRQ_SET_MASK_OK_NOCOPY;
> > }
> >
> > +static int mpic_irq_set_wake(struct irq_data *d, unsigned int on)
> > +{
> > + struct irq_desc *desc = container_of(d, struct irq_desc,
> > irq_data);
> > +
> > + if (on)
> > + desc->action->flags |= IRQF_NO_SUSPEND;
> > + else
> > + desc->action->flags &= ~IRQF_NO_SUSPEND;
> > +
> > + return 0;
> > +}
>
> This should really be something like fsl_mpic_irq_set_wake() and
only
> set when we have an FSL MPIC.
>
Thanks, Add "#ifdef FSL_SOC" to control.
That's not what I meant. Check "mpic->flags & MPIC_FSL".
-Scott
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
