Jiri Olsa [jo...@redhat.com] wrote:
| On Tue, Dec 18, 2012 at 11:28:02PM -0800, Sukadev Bhattiprolu wrote:
| >
| > Rename EVENT_ATTR() and EVENT_PTR() PMU_EVENT_ATTR() and PMU_EVENT_PTR().
| > Make them global so they are available to all architectures.
| >
| > Further to allow architectures flexibility, have PMU_EVENT_PTR() pass in the
| > variable name as a parameter.
| >
| hi,
| the change looks ok apart from some nits below.
|
| There' another version of the x86 event attributes change
| I mentioned earlier:
|
| http://marc.info/?l=linux-kernel&m=135601815224373&w=2
|
| I'm not sure which one will make it in first, but you
| guys need to sync ;-) CC-ing Andi and Stephane.
One change that would help powerpc (and other architectures) is to move
the 'struct perf_pmu_events_attr' to say, include/linux/perf_event.h.
Each architecture can define EVENT_VAR(), EVENT_PTR() etc as needed.
|
| thanks,
| jirka
|
<snip>
| > +struct perf_pmu_events_attr {
| > + struct device_attribute attr;
| > + u64 id;
| > +};
| > +
| > +#define PMU_EVENT_PTR(_var) &_var.attr.attr
|
| this one seems superfluous as well, could be replaced by '&'
I guess that would encode the assumption that both the 'attr' fields are
the first in their respective structures. If so, an explicit comment beside
the fields would be useful.
Sukadev
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
