On Tue, 2012-12-11 at 11:18 +0530, Suzuki K. Poulose wrote: > On 12/03/2012 08:37 PM, Suzuki K. Poulose wrote: > > From: Suzuki K. Poulose <suz...@in.ibm.com> > > > > External/Decrement exceptions have lower priority than the Debug Exception. > > So, we don't have to disable the External interrupts before a single step. > > However, on BookE, Critical Input Exception(CE) has higher priority than a > > Debug Exception. Hence we mask them.
I'm not sure about that one ... >From memory, 4xx has that interesting issue which is that if you have single step enabled and an interrupt (of *any kind* occurs), the processor *will* step into the first instruction of the interrupt handler. (In fact, some silicons have a bug where it can even be the *second* instruction of the handler, which can be problematic when the first one is a branch). This is why you may notice that whole business we have in the handling of debug/crit interrupts where we try to figure out if that happened, and return with DE off if it did. Now, the above mentioned workaround means we might not need to disable EE indeed. However, in any case, I don't see what your patch fixes or improves, nor do I understand what you mean by "it is possible we'd get the single step reported for CE". Please explain in more details and describe the problematic scenario. Cheers, Ben. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
