On Mon, Oct 22, 2012 at 03:33:19AM +0000, Li Yang-R58472 wrote: > > > > -----Original Message----- > > From: Felipe Balbi [mailto:ba...@ti.com] > > Sent: Saturday, October 20, 2012 1:37 AM > > To: Simon Haggett > > Cc: Li Yang-R58472; Felipe Balbi; Greg Kroah-Hartman; linux- > > u...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux- > > ker...@vger.kernel.org; Laurent Pinchart > > Subject: Re: [PATCH 1/1] usb: gadget: Don't attempt to dequeue requests > > for a disabled USB endpoint on Freescale hardware > > > > Hi, > > > > On Fri, Oct 19, 2012 at 06:19:26PM +0100, Simon Haggett wrote: > > > Some gadget drivers may attempt to dequeue requests for an endpoint > > > that has already been disabled. For example, in the UVC gadget driver, > > > uvc_function_set_alt() will call usb_ep_disable() when alt setting 0 > > > is selected. When the userspace application subsequently issues the > > > VIDIOC_STREAMOFF ioctl, uvc_video_enable() invokes usb_ep_dequeue() to > > ensure that all requests have been cancelled. > > > > bug is on uvc gadget, then. Laurent ? > > > > Also, fsl should be removed from the tree, I'm trying to persuade iMX > > folks to use drivers/usb/chipidea instead. > > Besides the iMX usage, the driver is also being used by many Freescale > PowerPC/Coldfire SoCs. I agree that it's ideal to move to a common > driver. But it is a large task to make the chipidea driver works for > all the hardware that fsl_udc had supported and been tested on.
I understand that, but we just can't keep so many duplicated drivers in mainline. chipidea udc had at least 3 different implementations. Now it's the time to combine all of those and stick to a single driver. Just make a plan to slowly move towards chipidea in the upcoming few merge windows. I can continue to take in bugfixes for fsl_udc, but only if I see that you guys are working towards merging with chipidea driver. -- balbi
signature.asc
Description: Digital signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
