On Fri, 2012-06-08 at 11:49 +0530, Ananth N Mavinakayanahalli wrote: > On Fri, Jun 08, 2012 at 04:17:44PM +1000, Michael Ellerman wrote: > > On Fri, 2012-06-08 at 11:31 +0530, Ananth N Mavinakayanahalli wrote: > > > On Fri, Jun 08, 2012 at 03:51:54PM +1000, Michael Ellerman wrote: > > > > On Fri, 2012-06-08 at 10:06 +0530, Ananth N Mavinakayanahalli wrote: > > > > > > But MSR_PR=1 and hence emulate_step() will return -1 and hence we will > > > end up single-stepping using user_enable_single_step(). Same with rfid. > > > > Right. But that was exactly Jim's point, you may be asked to emulate > > those instructions even though you wouldn't expect to see them in > > userspace code, so you need to handle it. > > > > Luckily it looks like emulate_step() will do the right thing for you. > > It'd be good to test it to make 100% sure. > > Sure. Will add that check and send v2.
Sorry I didn't mean add a test in the code, I meant construct a test case to confirm that it works as expected. cheers _______________________________________________ Linuxppc-dev mailing list [email protected] https://lists.ozlabs.org/listinfo/linuxppc-dev
