On Fri, 2012-04-27 at 15:33 +0200, Borislav Petkov wrote: > this patch gives > > [ 8.278399] EDAC DEBUG: new_edac_mc_alloc: new_edac_mc_alloc: 0: dimm0 > (0:0:0): row 0, chan 0
One too many __func__'s in some combination of the pr_fmt and/or dbg call and/or the actual call site? > > diff --git a/drivers/edac/edac_core.h b/drivers/edac/edac_core.h [] > > @@ -447,8 +447,13 @@ static inline void pci_write_bits32(struct pci_dev > > *pdev, int offset, > > > > #endif /* CONFIG_PCI */ > > > > -extern struct mem_ctl_info *edac_mc_alloc(unsigned sz_pvt, unsigned > > nr_csrows, > > - unsigned nr_chans, int edac_index); > > +struct mem_ctl_info *edac_mc_alloc(unsigned sz_pvt, unsigned nr_csrows, > > + unsigned nr_chans, int edac_index); > > Why not "extern"? Using extern function prototypes in .h files isn't generally necessary nor is extern the more common kernel style. > > +static inline void edac_mc_handle_ce(struct mem_ctl_info *mci, > > unsigned long page_frame_number, > > unsigned long offset_in_page, > > unsigned long syndrome, int row, int channel, > > - const char *msg); > > Strange alignment, pls do > > static inline void edac_mc_handle_ce(struct..., > unsigned..., > ..., > ...); > or static inline void edac_mc_handle_ce(struct ..., etc) or static inline void edac_mc_handle_ce(...) _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
