On 26/02/12 23:37, Benjamin Herrenschmidt wrote: > On Tue, 2012-02-07 at 11:28 +0000, Martyn Welch wrote: >> Move the GE GPIO and PIC drivers to allow these to be used by non-86xx >> boards. > > Hi, Sorry for the late review... >
No problem, thanks for the review! >> Signed-off-by: Martyn Welch <martyn.we...@ge.com> >> --- >> arch/powerpc/platforms/86xx/Kconfig | 3 + >> arch/powerpc/platforms/86xx/Makefile | 7 +- >> arch/powerpc/platforms/86xx/gef_gpio.c | 171 -------------------- >> arch/powerpc/platforms/86xx/gef_pic.c | 252 >> ------------------------------ >> arch/powerpc/platforms/86xx/gef_pic.h | 11 -- >> arch/powerpc/platforms/86xx/gef_ppc9a.c | 3 +- >> arch/powerpc/platforms/86xx/gef_sbc310.c | 3 +- >> arch/powerpc/platforms/86xx/gef_sbc610.c | 3 +- >> arch/powerpc/platforms/Kconfig | 7 + >> arch/powerpc/platforms/Makefile | 3 + >> arch/powerpc/platforms/ge_gpio.c | 171 ++++++++++++++++++++ >> arch/powerpc/platforms/ge_pic.c | 252 >> ++++++++++++++++++++++++++++++ >> arch/powerpc/platforms/ge_pic.h | 11 ++ > > So I don't like having files showing up there. In fact, I want to move > the only other one here, it's not the right place for it > (fsl_uli1575.c). > This patch (or one like it) has been around for a while now. Kumar wanted me to put them here rather than sysdev[1], but I'm easy either way. > Please contemplate using arch/powerpc/sysdev instead. Maybe make a > subdir in there (geip or something like that ?) > I'd rather avoid "geip" (we seem to have a habit of renaming divisions), would "ge" be acceptable? > Also, use git mv so that the file moves appear as such in the history, > this will make review easier by clearly separating the move from actual > changes to the files. > Hmm, thought I'd done that. Will try again. Martyn [1] http://old.nabble.com/GE-GPIO-and-PIC-support.-td27212938.html -- Martyn Welch (Lead Software Engineer) | Registered in England and Wales GE Intelligent Platforms | (3828642) at 100 Barbirolli Square T +44(0)1327322748 | Manchester, M2 3AB E martyn.we...@ge.com | VAT:GB 927559189 _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
