On Thu, Feb 16, 2012 at 02:52:19PM -0800, Andrew Morton wrote: > On Thu, 16 Feb 2012 02:09:01 -0700 > Grant Likely <grant.lik...@secretlab.ca> wrote: > > This series generalizes the "irq_host" infrastructure from powerpc > > so that it can be used by all architectures and renames it to "irq_domain". > > drivers/mfd/twl-core.c is fairly horked on i386 allmodconfig: > > drivers/mfd/twl-core.c: In function 'twl_probe': > drivers/mfd/twl-core.c:1218: error: implicit declaration of function > 'irq_alloc_descs' > drivers/mfd/twl-core.c:1226: error: implicit declaration of function > 'irq_domain_add_legacy' > drivers/mfd/twl-core.c:1227: error: 'irq_domain_simple_ops' undeclared (first > use in this function) > drivers/mfd/twl-core.c:1227: error: (Each undeclared identifier is reported > only once > drivers/mfd/twl-core.c:1227: error: for each function it appears in.) > > This is today's linux-next so it has rmk's "ARM: omap: fix broken > twl-core dependencies and ifdefs" in there, which looks like it > attempts to repair this stuff.
Yes, you're the third to report this breakage. Grant's response on Tuesday over this was: | This is irq_domain related. It's related to an API change. I'm | tracking to get it solved, either by moving the twl commit into the | irqdomain branch or by deferring the api change to v3.5. | | I've also got a patch that converts x86 over to the new api, but I | don't have sufficient review to put it into the irqdomain tree yet. > btw, Russell, regarding this comment in include/linux/irq.h: > > /* > * Please do not include this file in generic code. There is currently > * no requirement for any architecture to implement anything held > * within this file. > * > * Thanks. --rmk > */ > > A quick grep indicates that we've lost this battle ;) Is the comments > still true? Should we stop discouraging inclusion of linux/irq.h? > Does anyone even know that it's discouraged ;) It's still true for any platform which hasn't been converted to genirq, as such a platform would not have asm/hw_irq.h. That said, since genirq, it's now necessary for any driver which contains interrupt controller code like GPIO drivers. So I suspect the comment should now be lost, even though it's not really a replacement for asm/irq.h. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
