On Wed, 2011-11-30 at 06:43 -0500, Josh Boyer wrote: > > That doesn't look right. The code is there doing something, why is it > just being removed? I would think the change would be to use > CONFIG_PPC_47x? > > Or if the code there isn't needed any longer, the changelog should say > why.
Ah right, I tripped on this one too when reviewing then figured it out but I agree, the changelog should be clearer. If you notice, the original ifdef was in a function that is only ever used on 44x. There's a separate function that handles 47x. I suppose this is a leftover of the initial port which somebody forgot to remove. So the patch is fine, but yes, the changelog could be made clearer. Cheers, Ben. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
