Hi Dmitry, On Thu, 17 Nov 2011 18:48:49 +0400 Dmitry Eremin-Solenikov <dbarysh...@gmail.com> wrote: > > Drop lots of unused headers after board files merge/splitup
Please inly drop include files if nothing in them is actually used. You need to do this by inspection, not by compilation testing. The problem is that indirect inclusions change over time and also depending on what CONFIG options are selected. Just a few examples below ... > diff --git a/arch/powerpc/platforms/83xx/km83xx.c > b/arch/powerpc/platforms/83xx/km83xx.c > index 65eb792..3b29e35 100644 > --- a/arch/powerpc/platforms/83xx/km83xx.c > +++ b/arch/powerpc/platforms/83xx/km83xx.c > @@ -11,35 +11,9 @@ > * option) any later version. > */ > > -#include <linux/stddef.h> > -#include <linux/kernel.h> > -#include <linux/init.h> > -#include <linux/errno.h> > -#include <linux/reboot.h> > -#include <linux/pci.h> > -#include <linux/kdev_t.h> > -#include <linux/major.h> > -#include <linux/console.h> > -#include <linux/delay.h> > -#include <linux/seq_file.h> > -#include <linux/root_dev.h> > -#include <linux/initrd.h> > -#include <linux/of_platform.h> > -#include <linux/of_device.h> Where is this file going to get its definition of "struct device_node" or "of_find_node_by_name"? > -#include <asm/system.h> > -#include <linux/atomic.h> > -#include <asm/time.h> > -#include <asm/io.h> > -#include <asm/machdep.h> or "ppc_md" or "define_machine"? -- Cheers, Stephen Rothwell s...@canb.auug.org.au http://www.canb.auug.org.au/~sfr/
pgpspXl9Sy3cK.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
