On 11/16/2011 03:55 AM, Zhao Chenhui wrote: > diff --git a/arch/powerpc/kernel/Makefile b/arch/powerpc/kernel/Makefile > index ce4f7f1..d5cc385 100644 > --- a/arch/powerpc/kernel/Makefile > +++ b/arch/powerpc/kernel/Makefile > @@ -63,6 +63,7 @@ obj-$(CONFIG_CRASH_DUMP) += crash_dump.o > ifeq ($(CONFIG_PPC32),y) > obj-$(CONFIG_E500) += idle_e500.o > endif > +obj-$(CONFIG_PPC_85xx) += l2cr_85xx.o
Can you restrict this to e500v1/v2? Also, don't call it "l2cr" -- that's a 6xx register that is not present on 85xx. > + .section .data > + .align 5 > +mpc85xx_sleep_save_area: > + .space STATE_SAVE_SIZE > +ccsrbase_low: > + .long 0 > +ccsrbase_high: > + .long 0 > +powmgtreq: > + .long POWMGTCSR_DPSLP_MASK > + > + .section .text > + .align 12 > + > + /* > + * r3 = high word of physical address of CCSR > + * r4 = low word of physical address of CCSR > + */ The whole point of powmgtreq is to store a dynamically-passed-in value... and it doesn't look like you add it in the jog patch. -Scott _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev