Yeah, send binding first should be better for reviewing entire set of patches.
Thanks!
-----Original Message-----
From: Wood Scott-B07421
Sent: Tuesday, November 15, 2011 1:37 AM
To: Liu Gang-B34182
Cc: Li Yang-R58472; Jiang Kai-B18973; linux-ker...@vger.kernel.org; Zang
Roy-R61911; alexandre.boun...@idt.com; a...@linux-foundation.org;
linuxppc-dev@lists.ozlabs.org; Gala Kumar-B11780
Subject: Re: [PATCH 4/5, v3] powerpc/8xxx: Update device tree bus probe for new
RapidIO node binding
On 11/14/2011 11:35 AM, Scott Wood wrote:
> On 11/12/2011 06:02 AM, Liu Gang wrote:
>> From: Kai Jiang <kai.ji...@freescale.com>
>>
>> Update of_platform_bus_probe() RapidIO node to be compitable with new
>> RapidIO dts compatible property.
>>
>> Signed-off-by: Kai Jiang <kai.ji...@freescale.com>
>> Signed-off-by: Kumar Gala <ga...@kernel.crashing.org>
>> ---
>> arch/powerpc/platforms/85xx/corenet_ds.c | 2 +-
>> arch/powerpc/platforms/85xx/mpc85xx_mds.c | 2 +-
>> arch/powerpc/platforms/86xx/mpc86xx_hpcn.c | 2 +-
>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/powerpc/platforms/85xx/corenet_ds.c
>> b/arch/powerpc/platforms/85xx/corenet_ds.c
>> index 802ad11..c48b661 100644
>> --- a/arch/powerpc/platforms/85xx/corenet_ds.c
>> +++ b/arch/powerpc/platforms/85xx/corenet_ds.c
>> @@ -112,7 +112,7 @@ static const struct of_device_id of_device_ids[]
>> __devinitconst = {
>> .compatible = "simple-bus"
>> },
>> {
>> - .compatible = "fsl,rapidio-delta",
>> + .compatible = "fsl,srio",
>
> fsl,srio is too vague. We need to identify the specific hardware (or
> at least a concrete programming interface document), not just the bus
> that the hardware implements.
Never mind, I see that the binding is more specific about what this string
means.
Next time have the binding come first. :-)
-Scott
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
