On Nov 10, 2011, at 12:55 PM, Scott Wood wrote:

> On Thu, Nov 10, 2011 at 12:42:54PM -0600, Kumar Gala wrote:
>> 
>> On Nov 10, 2011, at 12:10 PM, Scott Wood wrote:
>> 
>>> On Thu, Nov 10, 2011 at 10:14:11AM -0600, Kumar Gala wrote:
>>>> -          power@e0070{
>>>> -                  compatible = "fsl,mpc8536-pmc", "fsl,mpc8548-pmc",
>>>> -                               "fsl,p1022-pmc";
>>>> -                  reg = <0xe0070 0x20>;
>>>> -                  etsec1_clk: soc-clk@B0{
>>>> -                          fsl,pmcdr-mask = <0x00000080>;
>>>> -                  };
>>>> -                  etsec2_clk: soc-clk@B1{
>>>> -                          fsl,pmcdr-mask = <0x00000040>;
>>>> -                  };
>>>> -                  etsec3_clk: soc-clk@B2{
>>>> -                          fsl,pmcdr-mask = <0x00000020>;
>>>> -                  };
>>>> -          };
>>> 
>>> The compatibles on this node are wrong, but it looks like you're removing
>>> it altogether?
>>> 
>>> -Scott
>> 
>> Yeah, I think the whole thing needs to be relocated at because there are no 
>> etsec's on P1023, etc.  So will comment about this in commit message
> 
> Ah right, the etsec stuff should go as well. :-)
> 
> It should look like this:
> 
>       power@e0070 {
>               compatible = "fsl,p1023-pmc", "fsl,mpc8548-pmc";
>               reg = <0xe0070 0x20>;
>       };

What does being compatible with mpc8548-pmc mean?

- k
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to