On 11/08/2011 04:32 AM, Li Yang-R58472 wrote:
>> Subject: Re: [PATCH 3/7] powerpc/85xx: add sleep and deep sleep support
>>
>> On 11/04/2011 07:33 AM, Zhao Chenhui wrote:
>>> static int pmc_suspend_enter(suspend_state_t state)
>>> {
>>> int ret;
>>> + u32 powmgtreq = 0x00500000;
>>
>> Where does this 0x00500000 come from? Please symbolically define
>> individual bits.
>>
>> The comment in the asm code says it should be 0x00100000, BTW.
>
> I think we should get rid of the powmgtreq argument, as we don't support
> multiple modes for mpc85xx_enter_deep_sleep() now.
Doesn't that happen later in the patch series?
-Scott
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
