Kumar Gala wrote: >>> >> + phys_addr_t addr; >> > >> > Please add a comment here saying: >> > >> > 1) That 'addr' can be a virtual or physical address > The code and everything else makes that clear
I'm sorry, but I have to strongly disagree here. It is *NOT* clear that a variable of type 'phys_addr_t' can hold something that is not a physical address. -- Timur Tabi Linux kernel developer at Freescale _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
