On Wed, 21 Sep 2011 02:10:42 +0000
Tabi Timur-B04825 <b04...@freescale.com> wrote:
...
> The definitions of MFB_SET_PIXFMT and MFB_GET_PIXFMT are wrong:
>
> #define MFB_SET_PIXFMT 0x80014d08
> #define MFB_GET_PIXFMT 0x40014d08
>
> The "01" is the size. However, these ioctls take a __u32 as a parameter.
>
> This means that I have to fix the definitions to this:
>
> #define MFB_SET_PIXFMT _IOW('M', 8, __u32)
> #define MFB_GET_PIXFMT _IOR('M', 8, __u32)
>
> This will change the values and break binary compatibility with your
> applications. Are you okay with that?
yes. the app will be fixed for updated kernel.
> > Other ioctls can be removed. I'm not sure if someone
> > uses FBIOGET_GWINFO. If there are no objections from
> > other people, it can also be dropped.
>
> I'm going to remove FBIOGET_GWINFO because no one is using it, and the
> ioctl value is malformed (it doesn't define a direction or size).
okay.
Thanks,
Anatolij
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
