On Wed, 17 Aug 2011 05:44:56 +0800, Scott Wood <scottw...@freescale.com> wrote:

On 08/16/2011 04:25 AM, Chunhe Lan wrote:
Flash(cfi-flash, jedec-flash, and so on) nodes with the
property status="disabled" are not usable and so avoid
adding "disabled" flash devices with the system.

Signed-off-by: Chunhe Lan <chunhe....@freescale.com>
---
 drivers/mtd/maps/physmap_of.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/mtd/maps/physmap_of.c b/drivers/mtd/maps/physmap_of.c
index d251d1d..812e6dc 100644
--- a/drivers/mtd/maps/physmap_of.c
+++ b/drivers/mtd/maps/physmap_of.c
@@ -219,6 +219,9 @@ static int __devinit of_flash_probe(struct platform_device *dev)
        struct mtd_info **mtd_list = NULL;
        resource_size_t res_size;

+       if (!of_device_is_available(dp))
+               return -ENODEV;
+
        match = of_match_device(of_flash_match, &dev->dev);
        if (!match)
                return -EINVAL;

Are you actually seeing unavailable devices get probed?  I thought the
upper layers were supposed to prevent that.

   You are right.
   The upper layers have prevented unavailable devices.
   So, this patch is no need.

   Thanks.

   -Jack Lan

-Scott


_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to