On Aug 9, 2011, at 3:59 PM, Robin Holt wrote: > I guess my poor wording may have gotten me in trouble. I am getting > ready to repost this patch, but I want to ensure I am getting it as > right as possible. > > I think I should reword the commit message to indicate we are removing > the Documentation/.../fsl-flexcan.txt file which has essentially become > empty and change the p1010si.dtsi file's can nodes to "fsl,p1010-flexcan", > "fsl,flexcan". Is that correct? > > Thanks, > Robin
This is wrong. Again, what binding covers "fsl,flexcan" if you remove fsl-flexcan.txt: [galak@right powerpc]$ git grep flexcan Documentation/devicetree/bindings Documentation/devicetree/bindings/net/can/fsl-flexcan.txt:fsl,flexcan-v1.0 nodes Documentation/devicetree/bindings/net/can/fsl-flexcan.txt:- fsl,flexcan-clock-source : CAN Engine Clock Source.This property selects Documentation/devicetree/bindings/net/can/fsl-flexcan.txt:- fsl,flexcan-clock-divider : for the reference and system clock, an additional Documentation/devicetree/bindings/net/can/fsl-flexcan.txt: - v1.0 of flexcan-v1.0 represent the IP block version for P1010 SOC. Documentation/devicetree/bindings/net/can/fsl-flexcan.txt: compatible = "fsl,flexcan-v1.0"; Documentation/devicetree/bindings/net/can/fsl-flexcan.txt: fsl,flexcan-clock-source = "platform"; Documentation/devicetree/bindings/net/can/fsl-flexcan.txt: fsl,flexcan-clock-divider = <2>; Not seeing anything that covers it. I think the issue should be resolved by patching fsl-flexcan.txt to remove wording or update it. - k _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
