On Thu, 14 Jul 2011 10:01:42 +0800 Shaohui Xie <shaohui....@freescale.com> wrote:
> From: Kai.Jiang <kai.ji...@freescale.com> > > Parameter offset_in_page in function edac_mc_handle_ce should be masked > the higher bits above the page size, not the lower bits. The original input > sometimes causes crash. > > Signed-off-by: Kai.Jiang <kai.ji...@freescale.com> > --- > drivers/edac/mpc85xx_edac.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c > index 38ab8e2..b048a5f 100644 > --- a/drivers/edac/mpc85xx_edac.c > +++ b/drivers/edac/mpc85xx_edac.c > @@ -854,11 +854,11 @@ static void mpc85xx_mc_check(struct mem_ctl_info *mci) > mpc85xx_mc_printk(mci, KERN_ERR, "PFN out of range!\n"); > > if (err_detect & DDR_EDE_SBE) > - edac_mc_handle_ce(mci, pfn, err_addr & PAGE_MASK, > + edac_mc_handle_ce(mci, pfn, err_addr & ~PAGE_MASK, > syndrome, row_index, 0, mci->ctl_name); > > if (err_detect & DDR_EDE_MBE) > - edac_mc_handle_ue(mci, pfn, err_addr & PAGE_MASK, > + edac_mc_handle_ue(mci, pfn, err_addr & ~PAGE_MASK, > row_index, mci->ctl_name); > > out_be32(pdata->mc_vbase + MPC85XX_MC_ERR_DETECT, err_detect); The patch should have had your Signed-off-by:, as described in Documentation/SubmittingPatches. I added your s-o-b to my copy - please ack this. >From the description it appears to me that this fix should be backported into 2.6.39.x and earlier. Do you agree? The way to indicate this intention is to add "Cc: <sta...@kernel.org>" to the changelog. I added that tag to my copy of this patch. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
