On Jun 5, 2011, at 9:48 PM, Michael Neuling wrote:
> doorbell type is defined as bits 32:36 so should be shifted by 63-36 =
> 27 rather than 28.
>
> We never noticed this bug as we've only every used type PPC_DBELL = 0.
>
> Signed-off-by: Michael Neuling <mi...@neuling.org>
> ---
> arch/powerpc/include/asm/dbell.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Kumar Gala <ga...@kernel.crashing.org>
>
> Index: linux-ozlabs/arch/powerpc/include/asm/dbell.h
> ===================================================================
> --- linux-ozlabs.orig/arch/powerpc/include/asm/dbell.h
> +++ linux-ozlabs/arch/powerpc/include/asm/dbell.h
> @@ -18,7 +18,7 @@
> #include <asm/ppc-opcode.h>
>
> #define PPC_DBELL_MSG_BRDCAST (0x04000000)
> -#define PPC_DBELL_TYPE(x) (((x) & 0xf) << 28)
> +#define PPC_DBELL_TYPE(x) (((x) & 0xf) << (63-36))
> enum ppc_dbell {
> PPC_DBELL = 0, /* doorbell */
> PPC_DBELL_CRIT = 1, /* critical doorbell */
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
