On Tue, May 03, 2011 at 11:50:22AM +1000, Benjamin Herrenschmidt wrote: > On Thu, 2011-04-28 at 14:02 -0600, Grant Likely wrote: > > This patch creates a common implementation of irq_of_create_mapping() > > and factors out the interrupt domain translation code from powerpc to > > make it available for all architectures. > > I think you are going the wrong way around. > > First thing first, is to make the irq domain / mapping API generic > without the OF bits. > > IE. move the IRQ domain generically, get rid of irq_map by putting the > domain ptr & hw numbers in the irq desc/data etc... > > Then you can move over the OF specific bits which are optional and > orthogonal to a large extent.
As discussed in my other reply, I disagree. There isn't an immediate need for the mapping interface in common code. It would be useful, sure, for some interrupt controllers, but for many of them irq_alloc_descs() and an irq_base value is all the functionality that is needed, and irq_host doesn't gain anything. The OF translation on the other hand is needed immediately by several architectures and are very much non-optional in that regard. g. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
