On Tue, 2011-04-05 at 16:13 +1000, Benjamin Herrenschmidt wrote: > Signed-off-by: Benjamin Herrenschmidt <b...@kernel.crashing.org> > --- > arch/powerpc/kernel/rtas.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/arch/powerpc/kernel/rtas.c b/arch/powerpc/kernel/rtas.c > index 2097f2b..c2bfc4d 100644 > --- a/arch/powerpc/kernel/rtas.c > +++ b/arch/powerpc/kernel/rtas.c > @@ -591,6 +591,8 @@ bool rtas_indicator_present(int token, int *maxindex) > u32 maxindex; > } *indicators; > > + if (!rtas.dev) > + return false; > indicators = of_get_property(rtas.dev, "rtas-indicators", &proplen); > if (!indicators) > return false;
Why? of_get_property() returns NULL if np is NULL, implemented in of_find_property(). It doesn't look like a fast path. cheers
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
