Hi,

On Sun, Apr 03, 2011 at 04:16:53PM -0700, tma...@apm.com wrote:
> +const char *op_state_str(enum usb_otg_state state)

please don't introduce yet another version of this. Make the ones
available generic. Place a static inline const char
*otg_state_string(struct otg_transceiver *x) on include/linux/usb/otg.h

> +/**
> + * This function enables the controller's Global Interrupt in the AHB Config
> + * register.
> + */

useless comments :-) or convert to kerneldoc.

-- 
balbi
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to