On Wed, 2011-03-02 at 14:37 +1100, Benjamin Herrenschmidt wrote: > On Mon, 2011-02-07 at 19:29 +1100, David Gibson wrote: > > On Wed, Feb 02, 2011 at 06:00:25PM -0600, Dave Kleikamp wrote: > > > On Thu, 2011-02-03 at 10:06 +1100, David Gibson wrote: > > > > On Tue, Feb 01, 2011 at 12:48:41PM -0600, Dave Kleikamp wrote: > > > > > so that it can use information from the device tree. > > > > > > > > Hrm. On the other hand this means that the early_init_devtree() code > > > > can't benefit from hardcoded early debugging. Since you don't > > > > actually appear to use devtree information in udbg_early_init() in the > > > > latest series, I'd suggest dropping this patch. > > > > > > Patch 2 depends on early_init_devtree() being run. Until then, I don't > > > know of a way to get at the bootargs. > > > > Ah, yes. Drat. > > Doesn't matter. _Early_ debug has (or should have) the address in > the .config file anyways, so it really shouldn't have to care about the > arguments. > > So I'll drop this patch. > > There are plenty of reasons why we want to be able to use the early > debug stuff to debug what's happening inside early_init_devtree() :-)
Fair enough. I wasn't sure this was the right thing to do. It's either turn off early debug for AMP, or build separate kernels with a different address in .config. Shaggy _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev