Hello Paul,
Paul Mundt wrote:
> On Tue, Jan 25, 2011 at 07:45:46AM +0100, Heiko Schocher wrote:
>> @@ -197,6 +198,15 @@
>> #address-cells = <1>;
>> };
>>
>> + display@1,0 {
>> + compatible = "smi,sm501";
>> + reg = <1 0x00000000 0x00800000
>> + 1 0x03e00000 0x00200000>;
>> + mode = "640x480-32@60";
>> + interrupts = <1 1 3>;
>> + little-endian;
>> + };
>> +
>
> The endian designation looks good, but it still doesn't explain why you
> have a remaining CONFIG_PPC_MPC52xx ifdef encapsulating the property
> check in the sm501fb patch. It shouldn't be needed at all. If the
> platform supports OF then the property will need to be set one way or the
> other, so there is no need for any board or CPU ifdeffery within the
> driver itself.
Argh, of course you are right, thanks! I post an update for the
"sm501fb of support" patch.
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
