On Fri, Dec 03, 2010 at 01:43:37PM -0600, Timur Tabi wrote: >Josh Boyer wrote: >> Just the moving of the clear_bit inside the #ifndef >> CONFIG_WATCHDOG_NOWAYOUT. > >If I move the clear_bit() call inside the #ifndef, then when >CONFIG_WATCHDOG_NOWAYOUT is defined, after a process closes /dev/watchdog, no >process will ever be able to open it again. Are you saying that once >wd_keepalive exits, you don't want anyone to be able to open /dev/watchdog and >ping the timer again?
Oh, good point. No, I don't think we want that. So in that case: Acked-by: Josh Boyer <jwbo...@linux.vnet.ibm.com> and sorry for the hassle. josh _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev