Hi Jesper, On Mon, 01 Nov 2010 22:10:42 +1100 Michael Ellerman <mich...@ellerman.id.au> wrote: > > On Sat, 2010-10-30 at 19:20 +0200, Jesper Juhl wrote: > > > > If memory is tight and a dynamic allocation fails there's no reason to > > make a bad situation worse by leaking memory. > > > > mf_getSrcHistory potentially leaks pages[0-3]. I believe the right thing > > to do is to free that memory again before returning -ENOMEM - which is > > what this patch does. > > > > I realize that the function is under '#if 0' so this probably doesn't > > matter much, but I assume that the function is still there for a reason > > (but I could be wrong, I don't know the powerpc code). > > Anyway, I suggest we remove the leak. > > Stephen is the iSeries maintainer, and I think he #if 0'ed the code. But > I don't think it will ever be un-ifdef'ed, so should probably just be > removed.
Well, only unofficially iseries maintainer :-) Yes, just remove the whole function ... it was never used and never will be. -- Cheers, Stephen Rothwell s...@canb.auug.org.au http://www.canb.auug.org.au/~sfr/
pgpESOlwQ0K5V.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
