On Oct 13, 2010, at 9:04 PM, Shaohui Xie wrote:

> From: Li Yang <[email protected]>
> 
> The access to HID1 register is only legitimate for e500 v1/v2 cores.
> Also fixes magic number.
> 
> Signed-off-by: Li Yang <[email protected]>
> Signed-off-by: Shaohui Xie <[email protected]>
> ---
> arch/powerpc/sysdev/fsl_rio.c |    9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/powerpc/sysdev/fsl_rio.c b/arch/powerpc/sysdev/fsl_rio.c
> index 4127636..dfff3b7 100644
> --- a/arch/powerpc/sysdev/fsl_rio.c
> +++ b/arch/powerpc/sysdev/fsl_rio.c
> @@ -1537,9 +1537,12 @@ int fsl_rio_setup(struct platform_device *dev)
> #ifdef CONFIG_E500
>       saved_mcheck_exception = ppc_md.machine_check_exception;
>       ppc_md.machine_check_exception = fsl_rio_mcheck_exception;
> -#endif
> -     /* Ensure that RFXE is set */
> -     mtspr(SPRN_HID1, (mfspr(SPRN_HID1) | 0x20000));
> +
> +#ifndef CONFIG_PPC_E500MC
> +     /* Ensure that RFXE is set on e500 v1/v2 */
> +     mtspr(SPRN_HID1, (mfspr(SPRN_HID1) | HID1_RFXE));
> +#endif /* !PPC_E500MC */
> +#endif /* E500 */

I've never really been happy with this code.  We really should set HID1_RFXE in 
cpu_setup_fsl_booke.S instead.

- k
_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to