On Fri, 01 Oct 2010 13:30:40 -0500
Nathan Fontenot <nf...@austin.ibm.com> wrote:

> Add a section count property to the memory_block struct to track the number
> of memory sections that have been added/removed from a memory block. This
> allows us to know when the last memory section of a memory block has been
> removed so we can remove the memory block.
> 
> Signed-off-by: Nathan Fontenot <nf...@austin.ibm.com>
> 

Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hir...@jp.fujitsu.com>

a nitpick,


> Index: linux-next/include/linux/memory.h
> ===================================================================
> --- linux-next.orig/include/linux/memory.h    2010-09-29 14:56:29.000000000 
> -0500
> +++ linux-next/include/linux/memory.h 2010-09-30 14:13:50.000000000 -0500
> @@ -23,6 +23,8 @@
>  struct memory_block {
>       unsigned long phys_index;
>       unsigned long state;
> +     int section_count;

I prefer
        int section_count; /* updated under mutex */

or some for this kind of non-atomic counters. but nitpick.

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to